Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored tools #64

Merged
merged 156 commits into from
Mar 1, 2024
Merged

Refactored tools #64

merged 156 commits into from
Mar 1, 2024

Conversation

danielhundhausen
Copy link
Collaborator

  • centralised objects definition for object performance and rate plots, table
  • python packaging with poetry
  • direct user CLI with object_performance rate_plots and rate_table

bonanomi and others added 30 commits June 29, 2023 09:27
@bonanomi
[cache_objects.py] Add status == 2 check on visible had taus
070355b
@bonanomi
Merge branch 'cms-l1-dpg:main' into main
015c320
@bonanomi
[Rates] Start development on rates table
6c11b52
@bonanomi
[Rates] Improvements and cleanup. Move to a single config
b58797f
@bonanomi
Clean up the code. Improve actions in config. Remove util functions f…
ded3cd2 
…rom menu config definition
@bonanomi
Cleaned up config for v29_WITHMUONS menu
c9df08b
@bonanomi
[v29_16Seeds] Scalings and minor modifications for full synch on v29_…
645265b 
…16Seeds menu (Double and TripleTkMuon slightly off)
@bonanomi
Add README
41a1be1
@artlbv
Move old menu tool to separate folder
dfeec58
@artlbv
Add loading math package
e6c1871
@artlbv
Fix scalings for caloTau and sc jets
3db4eab
@artlbv
Add pyc files to git ignore
14508a4
@artlbv
Change >= to > in Tau seeds in v29 config
c8d3898
@artlbv
Removing skipping Tau seeds
031d667
@artlbv
Add full menu and 16seed menu v29 steering file
1e3abf5
@artlbv
Fix MHT scalings
9e95004
@artlbv
Remove unused doublemu seed
35a0829
@artlbv
Remove colon from old fwk printout
d407e80
@artlbv
Introduce tkIsoEle fix and fix scalings and menu
4a10178
@artlbv
Add dump of masks
43a655b
@artlbv
Fix seed threshold
acc07d1
@bonanomi
Merge branch 'main' into new_rate_fwk
b0c0451
@bonanomi
Merge pull request #1 from artlbv/new_rate_fwk
4b721d6 
New rate fwk
@artlbv
Merge pull request #45 from bonanomi/main
31b470d 
Merge WIP new menu rate code into a separate branch
@danielhundhausen
move everything from objectPerformance
80117cb
@danielhundhausen
fix caching after move to menu_tools submodule
514558a
@danielhundhausen
fix object performance plotting after move to menu_tools submodule
ce5332f
@danielhundhausen
move caching yamls to dir where version dir is on higher level
adc2df3
@danielhundhausen
move object performance yamls to dir where version dir is on higher l…
2616300 
…evel
@danielhundhausen
add explicit commands for venv setup to README.md
dbc97b7
danielhundhausen and others added 26 commits February 5, 2024 10:12
@danielhundhausen
Merge pull request #17 from artlbv/dev_objects_artur
f7a8a94 
add json dump for rate plotter
@danielhundhausen
add seededConePuppiHT to rate plot
c833a7f
@danielhundhausen
make nicer progress bar
8719d26
@danielhundhausen
merge
655dc56
@danielhundhausen
remove unused import; reforamt; fix type hint
f2b09ca
@danielhundhausen
fix HT (event level) rate plots
38ec098
@danielhundhausen
add dump of rate plot config
a6a90b1
@danielhundhausen
add test to rate plots
df4a5e0
@danielhundhausen
Merge pull request #56 from danielhundhausen/dev_objects
00d6811 
Major refactoring, central objects, tests and more
@danielhundhausen
add build artifacts to gitignore
b2e2465
@artlbv
Fix Tau NNID
4251dcd
@artlbv
Merge pull request #57 from artlbv/dev_objects_artur
0aab1bb 
Fix Tau NNID
@danielhundhausen
change path of scaling files in rate plots
c6ab90f
@danielhundhausen
change output dir structure
93b4063
@danielhundhausen
improve V29 rate plots config
a863f59
@danielhundhausen
adapt test
b0b6566
@danielhundhausen
work on rate plots
a80e5bc
@artlbv
Merge pull request #60 from danielhundhausen/dev_output_hirarchy
da93e02 
Unify output hierarchy and update rate plot configs
@danielhundhausen
add gmtMuon quality cut in overlap region
5fd2d2b
@artlbv
Merge pull request #61 from danielhundhausen/validation_fixes
8b60bcf 
add gmtMuon quality cut in overlap region
@danielhundhausen
add dpg_trigger/.../cache as symlink to repo
b047bea
@danielhundhausen
remove quality cut <25GeV for tkElectrons
9a50326
@danielhundhausen
add NoIsoLowPt id for tkElectron
236b4a8
@danielhundhausen
remove xerr from efficiency plots
862382e
@danielhundhausen
create warning when scalings already exist and dump to different file…
d495a14 
…; add warning comments to tau config; fix tests after tkeleID change
@danielhundhausen
Merge pull request #63 from danielhundhausen/validation_fixes
07ce06d 
Add symlink to central cache directory
@artlbv
Copy link
Collaborator

artlbv commented Feb 28, 2024

how does rate_table work? there still seems to be the "old" rates folder and no rate_table in /menu_tools?

@artlbv artlbv self-assigned this Feb 29, 2024
@artlbv artlbv merged commit 73b1253 into main Mar 1, 2024
6 checks passed
@artlbv artlbv mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@artlbv artlbv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhundhausen @artlbv @bonanomi